On Mon, Apr 01, 2024 at 11:57:07AM -0400, Tom Lane wrote:
> Xing Guo <higuoxing@gmail.com> writes:
>> I'm playing a toy static analysis checker with PostgreSQL and found a
>> variable is missing volatile qualifier.
>
> Good catch! It looks like the consequences of a failure would be
> pretty minimal --- AFAICS, no worse than a possible failure to remove
> a refcount on Py_None --- but that's still a bug.
Huh. I seem to have dropped that "volatile" shortly before committing for
some reason [0].
> I don't care for your proposed fix though. I think the real problem
> here is schizophrenia about when to set up pltargs, and we could
> fix it more nicely as attached. (Perhaps the Asserts are overkill
> though.)
Your fix seems fine to me.
[0] https://postgr.es/m/20230504234235.GA2419591%40nathanxps13
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com