On Mon, Mar 18, 2024 at 09:22:43PM +0000, Amonson, Paul D wrote:
>> The only reason I left it out was because I couldn't convince myself that it
>> wasn't dead code, given we assume that popcntq is available in
>> pg_popcount64_fast() today. But I don't see any harm in adding that just in
>> case.
>
> I am not sure how to read this. Does this mean that for popcount32_fast
> and popcount64_fast I can assume that the x86(_64) instructions exists
> and stop doing the runtime checks for instruction availability?
I think my question boils down to "if pg_popcount_available() returns true,
can I safely assume I'm on a 64-bit machine?"
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com