On Mon, Mar 04, 2024 at 09:27:23PM +0100, Daniel Gustafsson wrote:
> Looks good from a read-through, I like it. A few comments on the commit
> message only:
>
> actionable details about the source of the miconfiguration. This
> s/miconfiguration/misconfiguration/
I reworded the commit message a bit to avoid the word "misconfiguration,"
as it felt a bit misleading to me. In any case, this was fixed, albeit
indirectly.
> Reviewed-by: Daniel Gustafsson, ¡lvaro Herrera
> Alvaro's name seems wrong.
Hm. It looks alright to me. I copied the name from his e-mail signature,
which has an accent over the first 'A'. I assume that's why it's not
showing up correctly in some places.
Anyway, I've committed this now. Thanks for taking a look!
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com