Hi,
On 2023-11-20 08:27:48 +0100, Peter Eisentraut wrote:
> On 17.11.23 19:53, Andres Freund wrote:
> > I pushed the first two commits (the selinux stuff) and worked a bit more on
> > the subsequent ones.
>
> Patches 0001 through 0004 look good to me.
Cool, I pushed them now.
> Some possible small tweaks in 0004:
>
> + perl, '-ne', 'next if /^#/; print',
>
> If you're going for super-brief mode, you could also use "perl -p" and drop
> the "print".
I thought this didn't add much, so I didn't go there.
> Put at least two spaces between the "columns" in targets-meson.txt:
>
> + doc/src/sgml/postgres-A4.pdf Build documentation in PDF format, with
> ^^
I did adopt this.
One remaining question is whether we should adjust install-doc-{html,man} to
be install-{html,man}, to match the docs targets.
Greetings,
Andres Freund