At Mon, 30 Oct 2023 03:36:41 +0000, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com> wrote in
> Thanks for the diff and I think the approach basically works.
>
> One notable behavior of this approach it will reject the GUC setting even if there
> are no slots on old cluster or user set the value to a big enough value which
> doesn't cause invalidation. The behavior doesn't look bad to me but just mention it
> for reference.
Indeed. pg_upgrade anyway sets the variable to -1 irrespective of the
slot's existence, and I see no justification for allowing users to
forcibly change it.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center