On Sat, Sep 02, 2023 at 09:08:22AM +0900, Michael Paquier wrote:
> On Fri, Sep 01, 2023 at 08:20:24AM -0700, Nathan Bossart wrote:
>> Something along those lines seems fine to me. FWIW this is what I had in
>> my head:
>>
>> It is important that MyDatabaseId only be set once we are sure that the
>> target database can no longer be concurrently dropped or renamed. Some
>> code depends on this. For example, without this guarantee,
>> pgstat_update_dbstats() could create entries for databases that were
>> just dropped, which will lead to problems down the road.
>
> I'm mostly OK with this formulation as well, but without the second
> sentence and adding as extra that pgstat_update_dbstats() could be
> specifically called in the shutdown callback of the shared statistics.
WFM
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com