Re: ProcessStartupPacket(): database_name and user_name truncation
От | Nathan Bossart |
---|---|
Тема | Re: ProcessStartupPacket(): database_name and user_name truncation |
Дата | |
Msg-id | 20230703203408.GA3090564@nathanxps13 обсуждение исходный текст |
Ответ на | Re: ProcessStartupPacket(): database_name and user_name truncation ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>) |
Ответы |
Re: ProcessStartupPacket(): database_name and user_name truncation
Re: ProcessStartupPacket(): database_name and user_name truncation |
Список | pgsql-hackers |
On Sat, Jul 01, 2023 at 04:02:06PM +0200, Drouvot, Bertrand wrote: > Please find V2 attached where it's failing as soon as the database name or > user name are detected as overlength. Thanks, Bertrand. I chickened out and ended up committing v1 for now (i.e., simply removing the truncation code). I didn't like the idea of trying to keep the new error messages consistent with code in faraway files, and the startup packet length limit is already pretty aggressive, so I'm a little less concerned about lugging around long names. Plus, I think v2 had some subtle interactions with db_user_namespace (maybe for the better), but I didn't spend too much time looking at that since db_user_namespace will likely be removed soon. If anyone disagrees and wants to see the FATALs emitted from ProcessStartupPacket() directly, please let me know and we can work on adding them in a follow-up patch. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
В списке pgsql-hackers по дате отправления: