Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX
От | Nathan Bossart |
---|---|
Тема | Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX |
Дата | |
Msg-id | 20230622030606.GA1074545@nathanxps13 обсуждение исходный текст |
Ответ на | Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX (Michael Paquier <michael@paquier.xyz>) |
Ответы |
Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX
|
Список | pgsql-hackers |
On Thu, Jun 22, 2023 at 10:46:41AM +0900, Michael Paquier wrote: > On Wed, Jun 21, 2023 at 10:16:24AM -0700, Nathan Bossart wrote: >>> I think that there is a testing gap with the coverage of CLUSTER. >>> "Ownership of partitions is checked" is a test that looks for the case >>> where regress_ptnowner owns the partitioned table and one of its >>> partitions, checking that the leaf not owned is skipped, but we don't >>> have a test where we attempt a CLUSTER on the partitioned table with >>> regress_ptnowner *not* owning the partitioned table, only one or more >>> of its partitions owned by regress_ptnowner. In this case, the >>> command would fail. >> >> We could add something for this, but it'd really just exercise the checks >> in RangeVarCallbackMaintainsTable(), which already has a decent amount of >> coverage. > > It seems to me that this has some value for the CLUSTER path, so I > would add a small thing for it. Done. > - /* > - * We already checked that the user has privileges to CLUSTER the > - * partitioned table when we locked it earlier, so there's no need to > - * check the privileges again here. > - */ > + if (!cluster_is_permitted_for_relation(relid, GetUserId())) > + continue; > I would add a comment here that this ACL recheck for the leaves is an > important thing to keep around as it impacts the case where the leaves > have a different owner than the parent, and the owner of the parent > clusters it. The only place in the tests where this has an influence > is the isolation test cluster-conflict-partition. Done. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
Вложения
В списке pgsql-hackers по дате отправления: