Hi,
On 2023-03-10 08:18:34 +0100, Peter Eisentraut wrote:
> Here is an updated patch. I have done some cosmetic polishing and fixed a
> minor Windows-related bug.
>
> In my mind, the patch is complete.
>
> If someone wants to do some in-depth code review, I suggest focusing on the
> following files:
>
> * src/backend/access/common/printtup.c
Have you done benchmarks of some simple workloads to verify this doesn't cause
slowdowns (when not using encryption, obviously)? printtup.c is a performance
sensitive portion for simple queries, particularly when they return multiple
columns.
And making tupledescs even wider is likely to have some price, both due to the
increase in memory usage, and due to the lower cache density - and that's code
where we're already hurting noticeably.
Greetings,
Andres Freund