Hi,
On 2023-02-17 10:00:41 -0800, Jeff Davis wrote:
> I guess I'm fine hacking pg_upgrade, but I think I'd like to make it
> conditional on this specific case: only perform the fixup if the old
> cluster is 15 or earlier and using libc and the newer cluster is 16 or
> later and using icu.
-1. That's just going to cause pain one major version upgrade further down the
line. Why would we want to incur that pain?
> There's already a check that the new cluster is empty, so I think it's
> safe to hack the pg_database locale fields.
I don't think we need to, we do issue the CREATE DATABASEs. So we just need to
make sure that includes the collation provider info, and the proper template
database, in pg_upgrade mode.
Greetings,
Andres Freund