Re: pg_walinspect memory leaks

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: pg_walinspect memory leaks
Дата
Msg-id 20230214005537.57zljs3hgmto7ajw@awork3.anarazel.de
обсуждение исходный текст
Ответ на pg_walinspect memory leaks  (Peter Geoghegan <pg@bowt.ie>)
Ответы Re: pg_walinspect memory leaks  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Список pgsql-hackers
Hi,

On 2023-02-13 15:22:02 -0800, Peter Geoghegan wrote:
> More concretely, it looks like GetWALRecordInfo() calls
> CStringGetTextDatum/cstring_to_text in a way that accumulates way too
> much memory in ExprContext.

Additionally, we leak two stringinfos for each record.


> This could be avoided by using a separate memory context that is reset
> periodically, or something else along the same lines.

Everything other than a per-row memory context that's reset each time seems
hard to manage in this case.

Somehwat funnily, GetWALRecordsInfo() then ends up being unnecessarily
dilligent about cleaning up O(1) memory, after not caring about O(N) memory...

Greetings,

Andres Freund



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Adding "large" to PG_TEST_EXTRA
Следующее
От: Nathan Bossart
Дата:
Сообщение: Re: recovery modules