Hi,
On 2023-02-01 09:49:00 -0800, Andres Freund wrote:
> On 2023-02-01 12:23:27 -0500, Tom Lane wrote:
> > And the minimum version appears to be newer than RHEL8's 1.8.2, which
> > I find pretty unfortunate. On RHEL8, it fails with
> > $ ninja
> > ninja: error: build.ninja:6771: multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing
listif it affects you
>
> What's in that line +- 2 lines? And/or what are the steps that got you
> to that point?
>
> I'll try building 1.8.2 and reproing.
>
>
> > I did manage to test this stuff on bleeding-edge Fedora,
> > but ...
>
> Yea, I worked a fair bit to avoid requiring a too new version, I'll try
> to figure out what went wrong. I did built on rhel8 not long ago, so I
> suspect it's a corner case somewhere.
Unfortunately the test script accidentally pulled in ninja from epel,
hence not noticing the issue.
There's three issues:
One is easy enough, albeit slightly annoying: 1.8.2 wants the
"depending" file only be named once in a dependency file. Slightly
uglier code in snowball_create.pl, but whatever.
The second is one case of multiple outputs with a depfile:
create_help.pl creates both sql_help.c and sql_help.h. Not immediately
sure what a good solution here is. The brute force solution would be to
invoke it twice, but I don't like that at all.
The last case is the various man directories. That'd be easy enough to
avoid if we generated them inside a man/ directory.
Greetings,
Andres Freund