Hi,
On 2023-01-20 19:00:08 -0800, Andres Freund wrote:
> Updated patch attached. I split it into multiple pieces.
> 1) A fix for [1], included here because I encountered it while testing
> 2) Introduction of libpq-be-fe-helpers.h
> 3) Convert dblink and postgres_fdw to the helper
> 4) Convert libpqwalreceiver.c to the helper
>
> Even if we eventually decide to backpatch 3), we'd likely not backpatch 4), as
> there's no bug (although perhaps the lack of FD handling could be called a
> bug?).
>
> There's also some light polishing, improving commit message, comments and
> moving some internal helper functions to later in the file.
After a tiny bit further polishing, and after separately pushing a resource
leak fix for walrcv_connect(), I pushed this.
Greetings,
Andres Freund