Hi,
On 2023-01-21 15:32:45 -0800, Peter Geoghegan wrote:
> Attached is my .clang-format, since you asked for it. It was
> originally based on stuff that both you and Peter E posted several
> years back, I believe. Plus the timescaledb one in one or two places.
> I worked a couple of things out through trial and error. It's
> relatively hard to follow the documentation, and there have been
> features added to newer LLVM versions.
Reformatting with your clang-format end up with something like:
Peter's:
2234 files changed, 334753 insertions(+), 289772 deletions(-)
Jelte's:
2236 files changed, 357500 insertions(+), 306815 deletions(-)
Mine (modified to reduce this):
2226 files changed, 261538 insertions(+), 256039 deletions(-)
Which is all at least an order of magnitude too much.
Jelte's uncrustify:
1773 files changed, 121722 insertions(+), 125369 deletions(-)
better, but still not great. Also had to prevent a file files it choked on
from getting reindented.
I think the main issue with either is that our variable definition indentation
just can't be emulated by the tools as-is.
Some tools can indent variable definitions so that the variable name starts on
the same column. Some can limit that for too long type names. But so far I
haven't seen one that cn make that column be column +12. They all look to
other surrounding types.
I hate that variable name indentation with a fiery passion. But switching away
from that intermixed with a lot of other changes isn't going to be fun.
Greetings,
Andres Freund