Re: Lazy allocation of pages required for verifying FPI consistency

Поиск
Список
Период
Сортировка
От Kyotaro Horiguchi
Тема Re: Lazy allocation of pages required for verifying FPI consistency
Дата
Msg-id 20230112.172928.1580283305055467792.horikyota.ntt@gmail.com
обсуждение исходный текст
Ответ на Lazy allocation of pages required for verifying FPI consistency  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Ответы Re: Lazy allocation of pages required for verifying FPI consistency
Re: Lazy allocation of pages required for verifying FPI consistency
Список pgsql-hackers
At Mon, 9 Jan 2023 20:00:00 +0530, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote in 
> I propose to statically allocate these two pages using PGAlignedBlock
> structure lazily in verifyBackupPageConsistency() to not waste dynamic
> memory worth 2*BLCKSZ bytes. I'm attaching a small patch herewith.
> 
> Thoughts?

IMHO, it's a bit scaring to me to push down the execution stack by
that large size. I tend to choose the (current) possible memory
wasting only on startup process than digging stack deeply.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Melih Mutlu
Дата:
Сообщение: Re: Allow logical replication to copy tables in binary format
Следующее
От: Julien Rouhaud
Дата:
Сообщение: Re: Lazy allocation of pages required for verifying FPI consistency