Re: Generate pg_stat_get_* functions with Macros
От | Nathan Bossart |
---|---|
Тема | Re: Generate pg_stat_get_* functions with Macros |
Дата | |
Msg-id | 20221204173207.GA2669116@nathanxps13 обсуждение исходный текст |
Ответ на | Re: Generate pg_stat_get_* functions with Macros ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>) |
Ответы |
Re: Generate pg_stat_get_* functions with Macros
|
Список | pgsql-hackers |
On Sun, Dec 04, 2022 at 06:07:37AM +0100, Drouvot, Bertrand wrote: > On 12/3/22 9:16 PM, Nathan Bossart wrote: >> Thanks. I editorialized a bit in the attached v3. I'm not sure that my >> proposed names for the macros are actually an improvement. WDYT? > > Thanks! I do prefer the macros definition ordering that you're proposing (that makes pgstatfuncs.c "easier" to read). > > As far the names, I think it's better to replace "TAB" with "REL" (like in v4 attached): the reason is that those macroswill be used in [1] for both tables and indexes stats (and so we'd have to replace "TAB" with "REL" in [1]). > Having "REL" already in place reduces the changes that will be needed in [1]. Alright. I marked this as ready-for-committer. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
В списке pgsql-hackers по дате отправления: