On Mon, Nov 28, 2022 at 01:13:14AM +0100, Tomas Vondra wrote:
> Opinions? Considering this will need to be backpatches, it'd be good to
> get some feedback on the approach. I think it's fine, but it would be
> unfortunate to fix one issue but break BRIN in a different way.
> --- a/contrib/pageinspect/Makefile
> +++ b/contrib/pageinspect/Makefile
> @@ -22,7 +22,7 @@ DATA = pageinspect--1.10--1.11.sql \
> pageinspect--1.0--1.1.sql
> PGFILEDESC = "pageinspect - functions to inspect contents of database pages"
>
> -REGRESS = page btree brin gin gist hash checksum oldextversions
> +REGRESS = page btree brin gin gist hash checksum oldextversions brinbugs
I can't comment on the patch itself, but:
These changes to ./Makefile will also need to be made in ./meson.build.
Also (per cirrusci), the test sometimes fail since two parallel tests
are doing "CREATE EXTENSION".