Re: Allow file inclusion in pg_hba and pg_ident files
От | Julien Rouhaud |
---|---|
Тема | Re: Allow file inclusion in pg_hba and pg_ident files |
Дата | |
Msg-id | 20221124090724.n7amf5kpdhx6vb76@jrouhaud обсуждение исходный текст |
Ответ на | Re: Allow file inclusion in pg_hba and pg_ident files (Julien Rouhaud <rjuju123@gmail.com>) |
Ответы |
Re: Allow file inclusion in pg_hba and pg_ident files
|
Список | pgsql-hackers |
Hi, On Thu, Nov 24, 2022 at 02:37:23PM +0800, Julien Rouhaud wrote: > On Thu, Nov 24, 2022 at 02:07:21PM +0900, Michael Paquier wrote: > > On Wed, Nov 23, 2022 at 03:56:50PM +0800, Julien Rouhaud wrote: > > > The depth 0 is getting used quite a lot now, maybe we should have a define for > > > it to make it easier to grep, like TOP_LEVEL_AUTH_FILE or something like that? > > > And also add a define for the magical 10 for the max inclusion depth, for both > > > auth files and GUC files while at it? > > > > Sounds like a good idea to me, and it seems to me that this had better > > be unified between the GUCs (see ParseConfigFp() that hardcodes a > > depth of 0) and hba.c. It looks like they could be added to > > conffiles.h, as of CONF_FILE_START_{LEVEL,DEPTH} and > > CONF_FILE_MAX_{LEVEL,DEPTH}. Would you like to send a patch? So I went with CONF_FILE_START_DEPTH and CONF_FILE_MAX_DEPTH. Attached v22 that fixes it in all the places I found. > > Now, to the tests.. > > > > > Mmm, I haven't looked deeply so I'm not sure if the perl podules are aware of > > > it or not, but maybe we could somehow detect the used delimiter at the > > > beginning after normalizing the directory, and use a $DELIM rather than a plain > > > "/"? > > > > I am not sure. Could you have a look and see if you can get the CI > > back to green? The first thing I would test is to switch the error > > patterns to be regexps based on the basenames rather than the full > > paths (tweaking the queries on the system views to do htat), so as we > > avoid all this business with slash and backslash transformations. Apparently just making sure that the $node->data_dir consistently uses forward slashes is enough to make the CI happy, for VS 2019 [1] and MinGW64 [2], so done this way with an extra normalization step. [1] https://cirrus-ci.com/task/4944203946917888 [2] https://cirrus-ci.com/task/6070103853760512
Вложения
В списке pgsql-hackers по дате отправления: