Re: Catalog_xmin is not advanced when a logical slot is lost

On 2022-Nov-21, Ashutosh Bapat wrote:

> Maybe. In that case pg_get_replication_slots() should be changed. We
> should use the same criteria to decide whether a slot is invalidated
> or not at all the places.

Right.

> I am a fan of stricter, all-assumption-covering conditions. In case we
> don't want to check restart_lsn, an Assert might be useful to validate
> our assumption.

Agreed.  I'll throw in an assert.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/