On Fri, Oct 14, 2022 at 07:37:38PM -0400, Corey Huinker wrote:
> Patch applies.
> Passes make check and make check-world.
> Test coverage seems adequate.
>
> Coding is very clear and very much in the style of the existing code. Any
> quibbles I have with the coding style are ones I have with the overall
> pg-style, and this isn't the forum for that.
>
> I haven't done any benchmarking yet, but it seems that the main question
> will be the impact on ordinary DML statements.
>
> I have no opinion about the design debate earlier in this thread, but I do
> think that this patch is ready and adds something concrete to the ongoing
> discussion.
Thanks for taking a look! Here is a rebased version of the patch set.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com