On 2022-Nov-09, Justin Pryzby wrote:
> On Wed, Nov 09, 2022 at 06:00:40PM +0530, Bharath Rupireddy wrote:
> > 1. For ease of review, please split the test patch to 0002.
>
> This is just my opinion, but .. why ? Since it's easy to
> filter/skip/display a file, I don't think it's usually useful to have
> separate patches for tests or docs.
I concur with Justin. When a patch is bugfix and a test is added that
verifies it, I like to keep the test in a separate commit (for submit
purposes and in my personal repo -- not for the official push!) so that
I can git-checkout to just the test and make sure it fails ahead of
pushing the fix commit. But for a new feature, there's no reason to do
so.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/