Re: Incorrect include file order in guc-file.l
| От | Julien Rouhaud |
|---|---|
| Тема | Re: Incorrect include file order in guc-file.l |
| Дата | |
| Msg-id | 20221102060105.o5raimiuo2aopv4r@jrouhaud обсуждение исходный текст |
| Ответ на | Incorrect include file order in guc-file.l (Michael Paquier <michael@paquier.xyz>) |
| Ответы |
Re: Incorrect include file order in guc-file.l
Re: Incorrect include file order in guc-file.l |
| Список | pgsql-hackers |
Hi,
On Wed, Nov 02, 2022 at 02:29:50PM +0900, Michael Paquier wrote:
>
> While reviewing a different patch, I have noticed that guc-file.l
> includes sys/stat.h in the middle of the PG internal headers. The
> usual practice is to have first postgres[_fe].h, followed by the
> system headers and finally the internal headers. That's a nit, but
> all the other files do that.
>
> {be,fe}-secure-openssl.c include some exceptions though, as documented
> there.
Agreed, it's apparently an oversight in dac048f71eb. +1 for the patch.
В списке pgsql-hackers по дате отправления: