Hi,
On 2022-10-02 00:19:59 -0700, Andres Freund wrote:
> On 2022-10-01 23:56:59 -0700, Andres Freund wrote:
> > On 2022-09-12 09:58:37 +0200, Daniel Gustafsson wrote:
> > > Correct, fixed in the attached.
> >
> > Updated patch adding meson compatibility attached.
>
> Err, forgot to amend one hunk :(
That fixed it on all platforms but windows, due to copy-pasto. I really should
have stopped earlier yesterday...
> +/*-------------------------------------------------------------------------
> + *
> + * filter.h
> + * Common header file for the parser of filter file
> + *
> + * Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group
> + * Portions Copyright (c) 1994, Regents of the University of California
> + *
> + * src/bin/pg_dump/filter.h
> + *
> + *-------------------------------------------------------------------------
> + */
> +#ifndef FILTER_H
> +#define FILTER_H
> +#include "c.h"
c.h (and postgres.h, postgres_fe.h) shouldn't be included in headers.
This is a common enough mistake that I'm wondering if we could automate
warning about it somehow.
Greetings,
Andres Freund