Re: Refactor UnpinBuffer()

Поиск
Список
Период
Сортировка
От Nathan Bossart
Тема Re: Refactor UnpinBuffer()
Дата
Msg-id 20220928210828.GA3303@nathanxps13
обсуждение исходный текст
Ответ на Refactor UnpinBuffer()  (Aleksander Alekseev <aleksander@timescale.com>)
Ответы Re: Refactor UnpinBuffer()
Список pgsql-hackers
On Wed, Sep 28, 2022 at 08:14:23PM +0300, Aleksander Alekseev wrote:
> +       ResourceOwnerForgetBuffer(CurrentResourceOwner, b);
> +
>         /* not moving as we're likely deleting it soon anyway */
>         ref = GetPrivateRefCountEntry(b, false);
>         Assert(ref != NULL);
> -
> -       if (fixOwner)
> -               ResourceOwnerForgetBuffer(CurrentResourceOwner, b);

Is it safe to move the call to ResourceOwnerForgetBuffer() to before the
call to GetPrivateRefCountEntry()?  From my quick skim of the code, it
seems like it should be safe, but I thought I'd ask the question.
Otherwise, LGTM.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: problems with making relfilenodes 56-bits
Следующее
От: Thomas Munro
Дата:
Сообщение: Re: making relfilenodes 56 bits