Re: Refactor UnpinBuffer()

On Wed, Sep 28, 2022 at 08:14:23PM +0300, Aleksander Alekseev wrote:
> +       ResourceOwnerForgetBuffer(CurrentResourceOwner, b);
> +
>         /* not moving as we're likely deleting it soon anyway */
>         ref = GetPrivateRefCountEntry(b, false);
>         Assert(ref != NULL);
> -
> -       if (fixOwner)
> -               ResourceOwnerForgetBuffer(CurrentResourceOwner, b);

Is it safe to move the call to ResourceOwnerForgetBuffer() to before the
call to GetPrivateRefCountEntry()?  From my quick skim of the code, it
seems like it should be safe, but I thought I'd ask the question.
Otherwise, LGTM.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com