On 2022-Sep-27, Kyotaro Horiguchi wrote:
> By the way, this is not an issue caused by the proposed patch, I see
> the following message in the patch.
>
> - errdetail("Column list cannot be used for a partitioned table when %s is false.",
> + errdetail("Column list cannot be specified for a partitioned table when %s is false.",
> "publish_via_partition_root")));
>
> I think that the purpose of such separation of variable names is to
> unify multiple messages differing only by the names (to keep
> translation labor (relatively:p) low). In that sense, that separation
> here is useless since I see no chance of having the same message with
> another variable in future.
Well, it also reduces chances for typos and such, so while it's not
strictly necessary to do it this way, I tend to prefer it on new
messages. However, as you say it's not very interesting when there's no
possibility of duplication, so changing existing messages to this style
when we have no other reason to change the message, is not a useful use
of time. In this case we're changing the message in another way too, so
I think it's okay.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"La primera ley de las demostraciones en vivo es: no trate de usar el sistema.
Escriba un guión que no toque nada para no causar daños." (Jakob Nielsen)