Re: pgsql: Fix broken cast on MSVC

Поиск
Список
Период
Сортировка
От Julien Rouhaud
Тема Re: pgsql: Fix broken cast on MSVC
Дата
Msg-id 20220830022636.qrcbcecmhztbxrwa@jrouhaud
обсуждение исходный текст
Ответ на pgsql: Fix broken cast on MSVC  (John Naylor <john.naylor@postgresql.org>)
Ответы Re: pgsql: Fix broken cast on MSVC
Список pgsql-committers
Hi,

On Mon, Aug 29, 2022 at 10:45:43AM +0000, John Naylor wrote:
>
> +/*
> + * Exactly like vector32_is_highbit_set except for the input type, so it
> + * looks at each byte separately.
> + *
> + * [...]
> + */
> +#ifndef USE_NO_SIMD
> +static inline bool
> +vector32_is_highbit_set(const Vector32 v)
> [...]

Shouldn't the comment be "Exactly like vector8_is_highbit_set..."?

Also, is there any reason to not have a function prototype for this one?  As
far as I can see that's the only one that doesn't in simd.h.



В списке pgsql-committers по дате отправления: