On Wed, Jun 15, 2022 at 03:32:04PM -0400, Tom Lane wrote:
> Justin Pryzby <pryzby@telsasoft.com> writes:
> > But Petr has a point - pg_upgrade should aspire to catch errors in --check,
> > rather than starting and then leaving a mess behind for the user to clean up
>
> Agreed; pg_upgrade has historically tried to find problems similar to
> this. However, it's not just aggregates that are at risk. People
> might also have built user-defined plain functions, or operators,
> atop these functions. How far do we want to go in looking?
I wasn't yet able to construct a user-defined function which fails to reload.
> As for the query, I think it could be simplified quite a bit by
> relying on regprocedure literals, that is something like
Yes, thanks.
> Also, I think you need to check aggfinalfn too.
Done but maybe needs more cleanup.
> Also, I'd be inclined to reject system-provided objects by checking
> for OID >= 16384 rather than hard-wiring assumptions about things
> being in pg_catalog or not.
To me, oid>=16384 seems more hard-wired than namespace!='pg_catalog'.
This patch also resolves an issue with PQfinish()/dangling connections.
--
Justin