On Tue, Apr 12, 2022 at 11:19:40AM -0400, Tom Lane wrote:
> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
> > On 4/11/22 4:11 PM, Tom Lane wrote:
> >> This idea does somewhat address my unhappiness upthread about printing
> >> values with source = 'internal', but I see that it gets confused by
> >> some GUCs with custom show hooks, like unix_socket_permissions.
> >> Maybe it needs to be "source != 'default' AND setting != boot_val"?
>
> > Running through a few GUCs, that seems reasonable. Happy to test the
> > patch out prior to commit to see if it renders better.
>
> It'd just look like this, I think. I see from looking at guc.c that
> boot_val can be NULL, so we'd better use IS DISTINCT FROM.
I noticed this is showing "pre-computed" gucs, like:
shared_memory_size | 149MB
shared_memory_size_in_huge_pages | 75
I'm not opposed to that, but I wonder if that's what's intended / best.
--
Justin