Re: Assert in pageinspect with NULL pages

On Tue, Mar 15, 2022 at 06:32:44PM +0900, Michael Paquier wrote:

> +    if (!IS_BRIN(indexRel))
> +        ereport(ERROR,
> +                (errcode(ERRCODE_WRONG_OBJECT_TYPE),
> +                 errmsg("\"%s\" is not a %s index",
> +                        RelationGetRelationName(indexRel), "BRIN")));

If it were me, I'd write this without the extra parens around (errcode()).

> +-- Suppress the DETAIL message, to allow the tests to work across various
> +-- default page sizes.

I think you mean "various non-default page sizes" or "various page sizes".

-- 
Justin