Re: Fix overflow in justify_interval related functions
От | Nathan Bossart |
---|---|
Тема | Re: Fix overflow in justify_interval related functions |
Дата | |
Msg-id | 20220215042306.GA2228390@nathanxps13 обсуждение исходный текст |
Ответ на | Re: Fix overflow in justify_interval related functions (Joseph Koshakow <koshy44@gmail.com>) |
Ответы |
Re: Fix overflow in justify_interval related functions
|
Список | pgsql-hackers |
On Mon, Feb 14, 2022 at 08:35:43PM -0500, Joseph Koshakow wrote: > Good catch, I didn't think about that. Though if you are pre-justifying > the days, then I don't think it's possible for the second addition to > days to overflow. The maximum amount the days field could be after > the first justification is 29. I think we can simplify it further to the > attached patch. LGTM. I've marked this one as ready-for-committer. It's a little weird that justify_hours() and justify_days() can overflow in cases where there is still a valid interval representation, but as Tom noted, those functions have specific charters to follow. > + ereport(ERROR, > + (errcode(ERRCODE_DATETIME_VALUE_OUT_OF_RANGE), > + errmsg("interval out of range"))); nitpick: I think there is ordinarily an extra space before errmsg() so that it lines up with errcode(). -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
В списке pgsql-hackers по дате отправления: