Hi,
On 2021-11-10 11:07:02 +0100, Peter Eisentraut wrote:
> On 01.11.21 00:24, Andres Freund wrote:
> > Hi,
> >
> > Attached is an updated version of the meson patchset.
>
> Nanoreview: I think the patch
Thanks for looking!
> Subject: [PATCH v5 11/16] meson: prereq: Handle DLSUFFIX in msvc builds
> similar to other build envs.
>
> is good to go. It's not clear why it's needed in this context, but it seems
> good in general to make these things more consistent.
The way it was set between msvc and other builds is currently inconsistent
between msvc and other builds, by virtue of win32_port.h defining for msvc:
/* Things that exist in MinGW headers, but need to be added to MSVC */
#ifdef _MSC_VER
...
/* Pulled from Makefile.port in MinGW */
#define DLSUFFIX ".dll"
it'd have needed unnecessarily contorted logic to continue setting DLSUFFIX
via commandline for !msvc, given that the the meson stuff is the same for msvc
and !msvc.
Greetings,
Andres Freund