Re: Running tests under valgrind is getting slower at an alarming pace

Hi,

On 2021-10-06 09:47:54 -0700, Andres Freund wrote:
> I'll also try to figure out print a bit more detail about timing for each tap
> test, looks like I need to figure out how to pass PROVE_TEST='--timer' through
> the buildfarm. Shouldn't be too hard.

Turns out that the buildfarm already adds --timer. I added -j4 to allow for
some concurrency in tap tests, but unfortunately my animals fell over after
that (thanks Michael for noticing).

Looks like the buildfarm client code isn't careful enough quoting PROVE_FLAGS?

        my $pflags = "PROVE_FLAGS=--timer";
        if (exists $ENV{PROVE_FLAGS})
        {
                $pflags =
                  $ENV{PROVE_FLAGS}
                  ? "PROVE_FLAGS=$ENV{PROVE_FLAGS}"
                  : "";
        }

                @makeout =
                  run_log("cd $dir && $make NO_LOCALE=1 $pflags $instflags $taptarget");

Which doesn't work if pflags ends up as '-j4 --timer' or such...

Greetings,

Andres Freund