Re: Triage on old commitfest entries

On Sun, Oct 03, 2021 at 03:14:58PM -0400, Tom Lane wrote:
[...]
> 
> Here's what I found, along with some commentary about each one.
> 
> Patch        Age in CFs
> 
> Protect syscache from bloating with negative cache entries    23
>     Last substantive discussion 2021-01, currently passing cfbot
> 
>     It's well known that I've never liked this patch, so I can't
>     claim to be unbiased.  But what I see here is a lot of focus
>     on specific test scenarios with little concern for the
>     possibility that other scenarios will be made worse.
>     I think we need some new ideas to make progress.
>     Proposed action: RWF

if we RwF this patch we should add the thread to the TODO entry 
it refers to 

> 
> Transactions involving multiple postgres foreign servers    18
>     Last substantive discussion 2021-07, currently failing cfbot
> 
>     This has been worked on fairly recently, but frankly I'm
>     dubious that we want to integrate a 2PC XM into Postgres.
>     Proposed action: Reject
> 

Masahiko has marked the patch as RwF already

> schema variables, LET command    18
>     Last substantive discussion 2021-09, currently passing cfbot
> 
>     Seems to be actively worked on, but is it ever going to get
>     committed?
> 

I had already moved this to Next CF when I read this, but I found this 
sounds useful

> Remove self join on a unique column    16
>     Last substantive discussion 2021-07, currently passing cfbot
> 
>     I'm not exactly sold that this has a good planning-cost-to-
>     usefulness ratio.
>     Proposed action: RWF
> 

It seems there is no proof that this will increase performance in the
thread.
David you're reviewer on this patch, what your opinion on this is?

> Index Skip Scan    16
>     Last substantive discussion 2021-05, currently passing cfbot
> 
>     Seems possibly useful, but we're not making progress.
> 

Peter G mentioned this would be useful. What we need to advance this
one? 

> standby recovery fails when re-replaying due to missing directory which was removed in previous replay    13
>     Last substantive discussion 2021-09, currently passing cfbot
> 
>     This is a bug fix, so we shouldn't drop it.
> 

Moved to Next CF

> Remove page-read callback from XLogReaderState    12
>     Last substantive discussion 2021-04, currently failing cfbot
> 
>     Not sure what to think about this one, but given that it
>     was pushed and later reverted, I'm suspicious of it.
> 

I guess those are enough for a decision: marked as RwF
If this is useful a new patch would be sent.

> Incremental Materialized View Maintenance    12
>     Last substantive discussion 2021-09, currently passing cfbot
> 
>     Seems to be actively worked on.

Moved to Next CF

> 
> pg_upgrade fails with non-standard ACL    12
>     Last substantive discussion 2021-03, currently passing cfbot
> 
>     This is a bug fix, so we shouldn't drop it.
> 

Moved to Next CF

> Fix up partitionwise join on how equi-join conditions between the partition keys are identified    11
>     Last substantive discussion 2021-07, currently passing cfbot
> 
>     This is another one where I feel we need new ideas to make
>     progress.
>     Proposed action: RWF

It seems there has been no activity since last version of the patch so I
don't think RwF is correct. What do we need to advance on this one?

> 
> A hook for path-removal decision on add_path    11
>     Last substantive discussion 2021-03, currently passing cfbot
> 
>     I don't think this is a great idea: a hook there will be
>     costly, and it's very unclear how multiple extensions could
>     interact correctly.
>     Proposed action: Reject
> 

Any other comments on this one?

> Implement INSERT SET syntax    11
>     Last substantive discussion 2020-03, currently passing cfbot
> 
>     This one is clearly stalled.  I don't think it's necessarily
>     a bad idea, but we seem not to be very interested.
>     Proposed action: Reject for lack of interest
> 

Again, no activity after last patch. 

> SQL:2011 application time    11
>     Last substantive discussion 2021-10, currently failing cfbot
> 
>     Actively worked on, and it's a big feature so long gestation
>     isn't surprising.
> 

Moved to Next CF

> WITH SYSTEM VERSIONING Temporal Tables    11
>     Last substantive discussion 2021-09, currently failing cfbot
> 
>     Actively worked on, and it's a big feature so long gestation
>     isn't surprising.
> 

Moved to Next CF

> psql - add SHOW_ALL_RESULTS option    11
>     Last substantive discussion 2021-09, currently passing cfbot
> 
>     This got committed and reverted once already.  I have to be
>     suspicious of whether this is a good design.
> 

No activity after last patch

> Split StdRdOptions into HeapOptions and ToastOptions    10
>     Last substantive discussion 2021-06, currently failing cfbot
> 
>     I think the author has despaired of anyone else taking an
>     interest here.  Unless somebody intends to take an interest,
>     we should put this one out of its misery.
>     Proposed action: Reject for lack of interest
> 

The author of the patch claimed that a rebased version should happen at
mid-august but it hasn't happened. RwF seems reasonable to me, done
that.

-- 
Jaime Casanova
Director de Servicios Profesionales
SystemGuards - Consultores de PostgreSQL