Re: Added missing invalidations for all tables publication
| От | Kyotaro Horiguchi |
|---|---|
| Тема | Re: Added missing invalidations for all tables publication |
| Дата | |
| Msg-id | 20210831.173006.2232867434123922765.horikyota.ntt@gmail.com обсуждение исходный текст |
| Ответ на | Re: Added missing invalidations for all tables publication (vignesh C <vignesh21@gmail.com>) |
| Ответы |
Re: Added missing invalidations for all tables publication
|
| Список | pgsql-hackers |
At Tue, 31 Aug 2021 08:31:05 +0530, vignesh C <vignesh21@gmail.com> wrote in > On Tue, Aug 31, 2021 at 7:40 AM houzj.fnst@fujitsu.com > <houzj.fnst@fujitsu.com> wrote: > Thanks for the comment, I have slightly modified the test case which > will fail without the patch. Attached v2 patch which has the changes > for the same. The test works fine. The code looks fine for me except one minor cosmetic flaw. + if (!HeapTupleIsValid(tup)) + elog(ERROR, "cache lookup failed for publication %u", + pubid); The last two lines don't need to be separated. ((Almost) All other instance of the same error is written that way. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
В списке pgsql-hackers по дате отправления: