On Thu, Apr 08, 2021 at 11:34:25AM -0400, Bruce Momjian wrote:
>
> OK, let's get some details. First, pg_stat_statements.queryid already
> exists (no underscore), and I don't think anyone wants to change that.
>
> pg_stat_activity.queryid is new, but I can imagine cases where you would
> join pg_stat_activity to pg_stat_statements to get an estimate of how
> long the query will take --- having one using an underscore and another
> one not seems odd.
Indeed, and also being able to join with a USING clause rather than an ON could
also save some keystrokes. But unfortunately, we already have (userid, dbid)
on pg_stat_statements side vs (usesysid, datid) on pg_stat_activity side, so
this unfortunately won't fix all the oddities.