Re: Snapshot scalability patch issue

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: Snapshot scalability patch issue
Дата
Msg-id 20210215230840.qohkjkrlq7j35a57@alap3.anarazel.de
обсуждение исходный текст
Ответ на Snapshot scalability patch issue  (Peter Geoghegan <pg@bowt.ie>)
Ответы Re: Snapshot scalability patch issue
Список pgsql-hackers
Hi,

On 2021-02-14 18:42:18 -0800, Peter Geoghegan wrote:
> The call to heap_page_prune() within lazy_scan_heap() passes a bool
> literal ('false') as its fourth argument. But the fourth argument is
> of type TransactionId, not bool. This has been the case since the
> snapshot scalability work performed by commit dc7420c2c92. Surely
> something is amiss here.

Looks like I accidentally swapped the InvalidTransactionId and false
around - luckily they have the same actual bit pattern...

I do wish C could pass arguments by name.

I'll push something once I'm back at my computer...

Greetings,

Andres Freund



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Zhihong Yu
Дата:
Сообщение: Re: CREATE INDEX CONCURRENTLY on partitioned index
Следующее
От: Peter Smith
Дата:
Сообщение: Re: [HACKERS] logical decoding of two-phase transactions