Re: [PATCH] pgbench tap tests fail if the path contains a perl special character

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Дата
Msg-id 20202.1548035461@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character  (Raúl Marín Rodríguez <rmrodriguez@carto.com>)
Ответы Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character  (Fabien COELHO <coelho@cri.ensmp.fr>)
Список pgsql-hackers
=?UTF-8?B?UmHDumwgTWFyw61uIFJvZHLDrWd1ZXo=?= <rmrodriguez@carto.com> writes:
>> Pushed with that correction.
> Thanks a lot!

Hm, so bowerbird (a Windows machine) has been failing the pgbench tests
since this went in, cf

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2019-01-20%2004%3A57%3A01

I'm just guessing, but I suspect that bowerbird is using a path spec that
includes a backslash directory separator and that's somehow bollixing
things.  If so, we might be able to fix it by converting backslashes to
forward slashes before applying quotemeta().

It's also possible that on Windows, "glob" handles backslashes
differently than it does elsewhere, which would be harder to fix
--- that would bring back my original fear that the appropriate
quoting rules are different for "glob" than for regexes.

Andrew, any insight?

            regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: speeding up planning with partitions
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: COPY FROM WHEN condition