On Wed, Dec 2, 2020 at 05:57:01PM -0500, Stephen Frost wrote:
> * Bruce Momjian (bruce@momjian.us) wrote:
> > We were not going to use just redirects --- we were going to create a
> > page that had all the renames listed, with links to the new names.
>
> Maybe I'm the one who is confused here, but I thought there was
> objection to adding a new section/page which covers these topics (which
> is what Craig's original patch does)...? If there isn't an objection to
> that then it seems like we should move forward with it.
>
> If I'm following correctly, maybe there was some idea that we should
> have more things added to this section than just the recovery.conf bits,
> and perhaps we should, but that could certainly be done later. To be
> clear though, I don't think we need to do this in all cases- the
> existing flow for pg_xlogdump -> pg_waldump works pretty well. Maybe we
> add in a note here too if someone wants to but I don't think it's
> strictly necessary for the 'simple' rename cases.
>
> I also feel like that could be done once the section gets added, if
> someone wants to.
>
> Was there something else that I'm missing here in terms of what the
> concern is regarding Craig's patch..?
I think the ideal solution is to create a section for all the rename
cases and do all the redirects to that page. The page would list the
old and new name for each item, and would link to the section for each
new item.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee