On Sun, Nov 22, 2020 at 08:03:51PM +0100, Tomas Vondra wrote:
> attached is a significantly improved version of the patch, allowing
> defining extended statistics on expressions. This fixes most of the
> problems in the previous WIP version and AFAICS it does pass all
> regression tests (including under valgrind). There's a bunch of FIXMEs
> and a couple loose ends, but overall I think it's ready for reviews.
I was looking at the previous patch, so now read this one instead, and attach
some proposed fixes.
+ * This matters especially for * expensive expressions, of course.
+ The expression can refer only to columns of the underlying table, but
+ it can use all columns, not just the ones the statistics is defined
+ on.
I don't know what these are trying to say?
+ errmsg("statistics expressions and predicates can refer only to the table being
indexed")));
+ * partial-index predicates. Create it in the per-index context to be
I think these are copied and shouldn't mention "indexes" or "predicates". Or
should statistics support predicates, too ?
Idea: if a user specifies no stakinds, and there's no expression specified,
then you automatically build everything except for expressional stats. But if
they specify only one statistics "column", it gives an error. If that's a
non-simple column reference, should that instead build *only* expressional
stats (possibly with a NOTICE, since the user might be intending to make MV
stats).
I think pg_stats_ext should allow inspecting the pg_statistic data in
pg_statistic_ext_data.stxdexprs. I guess array_agg() should be ordered by
something, so maybe it should use ORDINALITY (?)
I hacked more on bootstrap.c so included that here.
--
Justin