On Wed, Oct 28, 2020 at 03:07:56PM +0900, Tatsuro Yamada wrote:
>Hi Michael-san and Hackers,
>
>On 2020/09/30 15:19, Michael Paquier wrote:
>>On Thu, Sep 17, 2020 at 02:55:31PM +0900, Michael Paquier wrote:
>>>Could you provide at least a rebased version of the patch? The CF bot
>>>is complaning here.
>>
>>Not seeing this answered after two weeks, I have marked the patch as
>>RwF for now.
>>--
>>Michael
>
>
>Sorry for the delayed reply.
>
>I re-based the patch on the current head and did some
>refactoring.
>I think the size of extended stats are not useful for DBA.
>Should I remove it?
>
I think it's an interesting / useful information, I'd keep it (in the
\dX+ output only, of course). But I think it needs to print the size
similarly to \d+, i.e. using pg_size_pretty - that'll include the unit
and make it more readable for large stats.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services