Re: Enumize logical replication message actions

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Enumize logical replication message actions
Дата
Msg-id 20201023013141.GA8393@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: Enumize logical replication message actions  (Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>)
Ответы Re: Enumize logical replication message actions  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Список pgsql-hackers
On 2020-Oct-22, Ashutosh Bapat wrote:

> On Thu, 22 Oct 2020 at 14:46, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
> wrote:

> > pg_send_logicalrep_msg_type() looks somewhat too-much.  If we need
> > something like that we shouldn't do this refactoring, I think.
> 
> Enum is an integer, and we want to send byte. The function asserts that the
> enum fits a byte. If there's a way to declare byte long enums I would use
> that. But I didn't find a way to do that.

I didn't look at the code, but maybe it's sufficient to add a
StaticAssert?



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro Horiguchi
Дата:
Сообщение: Re: Enumize logical replication message actions
Следующее
От: Andy Fan
Дата:
Сообщение: Would it be helpful for share the patch merge result from cfbot