Re: Some remaining htonl() and ntohl() calls in the code

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: Some remaining htonl() and ntohl() calls in the code
Дата
Msg-id 20201014204123.vcewobvt3bp4jr7h@alap3.anarazel.de
обсуждение исходный текст
Ответ на Some remaining htonl() and ntohl() calls in the code  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Some remaining htonl() and ntohl() calls in the code  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Hi,

On 2020-10-14 14:53:03 +0900, Michael Paquier wrote:
> Since 510b8cbf, we have in-core equivalents for htonl(), ntohl() & co
> through pg_bswap.h that allows to compile with a built-in function if
> the compiler used has one.
> 
> All the existing calls in the code tree have been changed with
> 0ba99c84 for performance reasons (except the libpq examples), however
> the FE/BE code of GSSAPI encryption code did not get this call in
> b0b39f7.  I think that we had better switch to the built-ins functions
> as well for this case.  The argument of consistency matters here, but
> also perhaps the argument of performance, where it may not be easy to
> measure a difference.

+1

Greetings,

Andres Freund



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: More aggressive vacuuming of temporary tables
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: Minor documentation error regarding streaming replication protocol