On Wed, Jun 10, 2020 at 01:45:02PM -0400, Robert Haas wrote:
> My spidey sense is tingling here, telling me that we need some actual
> benchmarking. Like, suppose we test the two patches under normal cases
> and under cases that are constructed to be as bad as possible for each
> of them. Or suppose we test this patch with the lock mitigation
> strategies and then remove the mitigations for some inexpensive
> command (e.g. SHOW) and then use pgbench to spam that command. Like
> you, I suspect that the locking mitigations are important in some
> workloads, but it would be good to have some figures to back that out,
> as well as to find out whether there's still too much overhead.
This patch has not received any replies after this comment for three
months, so I am marking it as returned with feedback. I agree that
this should be benchmarked carefully.
--
Michael