Re: Avoid incorrect allocation in buildIndexArray

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Avoid incorrect allocation in buildIndexArray
Дата
Msg-id 20200912085410.GA9495@paquier.xyz
обсуждение исходный текст
Ответ на Re: Avoid incorrect allocation in buildIndexArray  (Julien Rouhaud <rjuju123@gmail.com>)
Ответы Re: Avoid incorrect allocation in buildIndexArray
Список pgsql-hackers
On Fri, Sep 11, 2020 at 01:49:26PM +0200, Julien Rouhaud wrote:
> On Fri, Sep 11, 2020 at 1:39 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>> Any reason not to bail early as per the attached?
>
> +1

Makes sense to me.  This has also the advantage to cause a crash if
there is an attempt to refer to those empty arrays in case of future
refactoring, which is rather defensive.  By looking at
findObjectByOid(), I can also see that we check for a negative number,
so I concur with Ranier's comment to check after that on top of 0.
If there are no objections, I'll apply that on HEAD.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: proposal: possibility to read dumped table's name from file
Следующее
От: Julien Rouhaud
Дата:
Сообщение: Re: Avoid incorrect allocation in buildIndexArray