Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c)

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c)
Дата
Msg-id 20200911170104.GA7722@alvherre.pgsql
обсуждение исходный текст
Ответ на Simplified version of read_binary_file (src/backend/utils/adt/genfile.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Ответы Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c)
Список pgsql-hackers
On 2020-Sep-11, Ranier Vilela wrote:

> Hi,
> 
> read_binary_file seems a bit complicated when we want to read the rest of
> the file (-1 for bytes_to_read).

This code was very recently rewritten in 96d1f423f95d, and I doubt that
taking out half the algorithm without studying how it got that way is a
great idea.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: Weird corner-case failure mode for VPATH builds
Следующее
От: Ranier Vilela
Дата:
Сообщение: Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c)