On Wed, Sep 09, 2020 at 09:00:50PM -0500, Justin Pryzby wrote:
> What would you want the checkpointer's ps to say ?
>
> Normally it just says:
> postgres 3468 3151 0 Aug27 ? 00:20:57 postgres: checkpointer
Note that CreateCheckPoint() can also be called from the startup
process if the bgwriter has not been launched once recovery finishes.
> Or do you mean do the same thing as now, but one layer lower, like:
>
> @@ -8728,6 +8725,9 @@ CreateCheckPoint(int flags)
> + if (flags & CHECKPOINT_END_OF_RECOVERY)
> + set_ps_display("recovery checkpoint");
For the use-case discussed here, that would be fine. Now the
difficult point is how much information we can actually display
without bloating ps while still have something meaningful. Showing
all the information from LogCheckpointStart() would bloat the output a
lot for example. So, thinking about that, my take would be to have ps
display the following at the beginning of CreateCheckpoint() and
CreateRestartPoint():
- restartpoint or checkpoint
- shutdown
- end-of-recovery
The output also needs to be cleared once the routines finish or if
there is a skip, of course.
--
Michael