Re: psql - improve test coverage from 41% to 88%

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: psql - improve test coverage from 41% to 88%
Дата
Msg-id 20200803020619.GK3317@paquier.xyz
обсуждение исходный текст
Ответ на Re: psql - improve test coverage from 41% to 88%  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Список pgsql-hackers
On Sun, Aug 02, 2020 at 11:10:23AM -0400, Andrew Dunstan wrote:
> +1. Also note that the Windows animals don't and probably will never
> support Expect, since Windows doesn't have PTYs. Expect.pm is in fact a
> pure perl module that sits on top of IO::Pty, which in turn sits on top
> of IO::Tty. So if you have those Expect.pm probably isn't a huge
> stretch. But let's not add a dependency if we can avoid it. And if we do
> add one it will need to be a soft one like the case you mentioned.

Even with that, do we really care about some code coverage specific to
Windows for tab-complete.c?  Also, how complicated does the proposed
patch become if we remove the dependency to Expect.pm and just rely on
IO::Pty?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Thomas Munro
Дата:
Сообщение: Re: LDAP check flapping on crake due to race
Следующее
От: Masahiko Sawada
Дата:
Сообщение: Re: display offset along with block number in vacuum errors