Re: A patch for get origin from commit_ts.

>two things I missed a couple of hours back.  Why do you need

>pg_last_committed_xact_with_origin() to begin with?  Wouldn't it be

>more simple to just add a new column to pg_last_committed_xact() for

>the replication origin?  Contrary to pg_xact_commit_timestamp() that

>should not be broken for compatibility reasons because it returns only

>one value, we don't have this problem with pg_last_committed_xact() as

>it already returns one tuple with two values.

Yes make sense, changed in new patch.

 

>+{ oid => '4179', descr => 'get commit origin of a transaction',

>A second thing is that the OID of the new function should be in the

>range 8000..9999, as per the policy introduced in commit a6417078.

>src/include/catalog/unused_oids can be used to pick up a value.