Re: A patch for get origin from commit_ts.

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: A patch for get origin from commit_ts.
Дата
Msg-id 20200703051059.GB1729@paquier.xyz
обсуждение исходный текст
Ответ на Re: A patch for get origin from commit_ts.  (Petr Jelinek <petr@2ndquadrant.com>)
Ответы Re: A patch for get origin from commit_ts.  (Movead Li <movead.li@highgo.ca>)
Список pgsql-hackers
On Thu, Jul 02, 2020 at 10:12:02AM +0200, Petr Jelinek wrote:
> On 02/07/2020 03:58, michael@paquier.xyz wrote:
>> Adding a new function able to return both fields at the same time does
>> not imply that we'd remove the original one, it just implies that we
>> would be able to retrieve both fields with a single call of
>> TransactionIdGetCommitTsData(), saving from an extra CommitTsSLRULock
>> taken, etc.  That's actually what pglogical does with
>> its pglogical_xact_commit_timestamp_origin() in
>> pglogical_functions.c.  So adding one function able to return one
>> tuple with the two fields, without removing the existing
>> pg_xact_commit_timestamp() makes the most sense, no?
>
> Agreed, sounds reasonable.

Thanks.  Movead, please note that the patch is waiting on author?
Could you send an update if you think that those changes make sense?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Read access for pg_monitor to pg_replication_origin_status view
Следующее
От: "Andrey V. Lepikhov"
Дата:
Сообщение: Re: [POC] Fast COPY FROM command for the table with foreign partitions