On Mon, Jun 29, 2020 at 03:51:48PM -0400, Tom Lane wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
>> That being said, we do retain temporary files on such failures on purpose in
>> our TestLib since 88802e068017bee8cea7a5502a712794e761c7b5 and a few follow-up
>> commits since, should these be handled differently? They are admittedly less
>> "unknown" as compared to other files as they are copies, but famous last words
>> have been spoken about bugs that can never happen.
>
> Oh, good point. Objection withdrawn.
I looked at the patch, and can confirm that client_wrongperms_tmp.key
remains around after running 001_ssltests.pl, and client_tmp.key after
running 002_scram.pl. The way the patch does its cleanup looks fine
to me, so I'll apply and backpatch where necessary, if there are no
objections of course.
--
Michael